Fix --ignore-dependencies with stack_output
#779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where a users attempts to launch a single stack that utilises the `stack_output_resolver` with the `--ignore-dependencies`. Previously, with `--ignore-dependencies` set, any dependencies that arose through `!stack_output_resolver` would not be added to `stack.dependencies` and the `next()` function in `StackOutput.resolve()` would raise a `StopIteration` as the stack.dependencies list would be empty. This commit handles the stack_output by utilising the argument passed into `stack_output`. [Resolves #778]
ngfgrant
force-pushed
the
fix-single-stack-ignore-dep-stack-output
branch
from
638e7a8 to
905a0d6
Compare
|
There maybe an issue with this implementation as it assumes the |
|
I can confirm that it is an issue :/ |
|
This stale PR that was never merged for unknown reasons has drifted so much against the current master that I am closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where a users attempts to launch a single
stack that utilises the
stack_output_resolverwith the--ignore-dependencies.Previously, with
--ignore-dependenciesset, any dependencies that arosethrough
!stack_output_resolverwould not be added tostack.dependenciesand thenext()function inStackOutput.resolve()would raise aStopIterationas thestack.dependencies list would be empty.
This commit handles the stack_output by utilising the argument passed
into
stack_output.[Resolves #778]
PR Checklist
[Resolve #issue-number].make test) are passing.make lint) checks.and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit